[libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

Hans Wennborg via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 26 16:11:28 PST 2016


As per the discussion on http://reviews.llvm.org/D16408, I've merged
this in r258887.

On Thu, Jan 21, 2016 at 9:36 AM, Daniel Sanders
<Daniel.Sanders at imgtec.com> wrote:
> I'm not sure why my reply-all dropped Hans from the recipients. Re-added
> him.
>
>
>
> From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org] On Behalf Of
> Daniel Sanders via cfe-commits
> Sent: 21 January 2016 17:31
> To: Marshall Clow
> Cc: cfe-commits
> Subject: RE: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE'
> directives to tests that require en_US.UTF-8.
>
>
>
> I just took that as being humble. I'm happy to revert if you want.
>
>
>
> From: Marshall Clow [mailto:mclow.lists at gmail.com]
> Sent: 21 January 2016 17:29
> To: Daniel Sanders
> Cc: Hans Wennborg; cfe-commits
> Subject: Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE'
> directives to tests that require en_US.UTF-8.
>
>
>
> On Thu, Jan 21, 2016 at 9:27 AM, Daniel Sanders <Daniel.Sanders at imgtec.com>
> wrote:
>
> Hi,
>
>
>
> It was LGTM'd by bcraig.
>
>
>
> Specifically, he said "LGTM, but that doesn't mean much."
>
>
>
> -- Marshall
>
>
>
>
>
> From: Marshall Clow [mailto:mclow.lists at gmail.com]
> Sent: 21 January 2016 17:25
> To: Hans Wennborg
> Cc: Daniel Sanders; cfe-commits
> Subject: Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE'
> directives to tests that require en_US.UTF-8.
>
>
>
> On Thu, Jan 21, 2016 at 9:05 AM, Hans Wennborg <hans at chromium.org> wrote:
>
> Hi Marshall,
>
> Is this OK for 3.8?
>
>
>
> I have no idea; this is the first I've seen of it.
>
> Apparently it was posted on phab, no one approved it, and it was committed.
>
>
>
> In an hour.
>
>
>
> -- Marshall
>
>
>
>
>
>
>
>
> Daniel, I assume we want reviews.llvm.org/D16408 too when that lands, right?
>
> Thanks,
> Hans
>
>
> On Thu, Jan 21, 2016 at 7:35 AM, Daniel Sanders via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
>> Author: dsanders
>> Date: Thu Jan 21 09:35:15 2016
>> New Revision: 258403
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=258403&view=rev
>> Log:
>> [libcxx] Add appropriate 'REQUIRE' directives to tests that require
>> en_US.UTF-8.
>>
>> Reviewers: mclow.lists, hans
>>
>> Subscribers: bcraig, cfe-commits
>>
>> Differential Revision: http://reviews.llvm.org/D16406
>
>
>
>


More information about the cfe-commits mailing list