[PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

[David Blaikie via cfe-commits]

On Mon, Jan 25, 2016 at 6:20 PM, Eugene Zelenko via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Eugene.Zelenko created this revision.
> Eugene.Zelenko added reviewers: alexfh, aaron.ballman.
> Eugene.Zelenko added a subscriber: cfe-commits.
> Eugene.Zelenko set the repository for this revision to rL LLVM.
>
> I checked this patch on my own build on RHEL 6. Regressions were OK.
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D16566
>
> Files:
>   unittests/clang-tidy/IncludeInserterTest.cpp
>
> Index: unittests/clang-tidy/IncludeInserterTest.cpp
> ===================================================================
> --- unittests/clang-tidy/IncludeInserterTest.cpp
> +++ unittests/clang-tidy/IncludeInserterTest.cpp
> @@ -98,7 +98,7 @@
>  public:
>    CXXSystemIncludeInserterCheck(StringRef CheckName, ClangTidyContext
> *Context)
>        : IncludeInserterCheckBase(CheckName, Context) {}
> -  virtual ~CXXSystemIncludeInserterCheck() {}
> +  ~CXXSystemIncludeInserterCheck() override = default;
>

Perhaps we should just remove this user-declared dtor entirely? The
implicitly provided dtor will do all that by default anyway...


>
>    std::vector<StringRef> HeadersToInclude() const override { return
> {"set"}; }
>    bool IsAngledInclude() const override { return true; }
> @@ -522,7 +522,7 @@
>                                     "insert_includes_test_header.cc"));
>  }
>
> -} // namespace
> +} // anonymous namespace
>  } // namespace tidy
>  } // namespace clang
>
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160126/cde01a10/attachment.html>