[PATCH] D16501: [CUDA] Don't generate aliases for static extern "C" functions.

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 25 11:56:47 PST 2016

jlebar added a comment.

In http://reviews.llvm.org/D16501#335225, @tra wrote:

> Failing silently is not a good idea. At the very least there should produce an error.
>  The right thing to do here, IMO, would be to generate a stub with alias name that just jumps to or calls aliasee.

Discussed IRL.  We're not breaking anyone who's not already broken -- if you currently have "__device__ __attribute__((used)) static int foo()", that's just not going to compile for you without this patch.  With this patch, at least this will work for some people; we can always add this stub function later if we want (I have concerns about potentially surprising performance implications, but we can postpone worrying about that).


More information about the cfe-commits mailing list