[PATCH] D15836: [libcxx] Fix undefined behavior in forward_list

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 25 09:04:53 PST 2016


mclow.lists added a comment.

This looks good to me.


================
Comment at: include/forward_list:369
@@ +368,3 @@
+    }
+    __node_pointer __get_node_unchecked() const {
+        return static_cast<__node_pointer>(
----------------
I would think about calling this `__get_node_dereferencable` or something similar.
When I looked at this first, I wondered "is there another call that does checking?"



http://reviews.llvm.org/D15836





More information about the cfe-commits mailing list