[PATCH] D16286: [clang-tidy] Readability check for redundant parenthesis in return expression.

Richard via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 22 12:58:46 PST 2016


LegalizeAdulthood added a comment.

As a general comment, I am continually fascinated by the **huge** variety of opinion as to matters of readability within the C++ community.  I don't know why we have so many differing opinions compared to the communities built around other programming languages, but I enjoy hearing all of them.  I enjoy having my opinions on readability challenged because it forces me to think **why** I find one form preferable over another and that is a good thing.

In http://reviews.llvm.org/D16286#330390, @aaron.ballman wrote:

> In http://reviews.llvm.org/D16286#330360, @LegalizeAdulthood wrote:
>
> > One could argue that this check should be part of the google module.  The google style guide specifically forbids writing return with extra parenthesis.
>
>
> If it is meant to work for a particular style guide, then it should absolutely go under that style guide. But for something more generally under the readability-* umbrella, I think it doesn't hurt to discuss where to draw the line, or what options may be valuable.


I think that is the correct conclusion here; according to the bug report this check is motivated by the Google style guide which explicitly prohibits the parens for return expressions.


http://reviews.llvm.org/D16286





More information about the cfe-commits mailing list