[PATCH] D16344: [libcxx] Fix PR26103 - Error calling is_convertible with incomplete type

[Eric Fiselier via cfe-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM after addressing the `IncompleteClass` comment.

Thanks for the patch!


================
Comment at: test/std/utilities/meta/meta.rel/is_convertible.pass.cpp:217
@@ -209,1 +216,3 @@
+    // For example CannotInstantiate is instatiated as a part of ADL lookup for arguments of type CannotInstantiate*.
+    static_assert((std::is_convertible<CannotInstantiate<IncompleteClass>*, CannotInstantiate<IncompleteClass>*>::value), "");
 }
----------------
CannotInstantiate<int>* works too. Using `IncompleteClass` seems a little distracting because it has nothing to do with the class being incomplete. 
The test will fail in the exact same way when a complete class type is given.




http://reviews.llvm.org/D16344