[PATCH] D15935: Improve diagnostics for literal conversion to Boolean

[Manman Ren via cfe-commits]

manmanren added a subscriber: manmanren.
manmanren added a comment.

Thanks for working on this. This looks good to me overall, but I am not the expert on Sema :]

Cheers,
Manman


================
Comment at: lib/Sema/SemaChecking.cpp:6985
@@ -6984,6 +6984,3 @@
   SmallString<16> PrettyTargetValue;
-  if (T->isSpecificBuiltinType(BuiltinType::Bool))
-    PrettyTargetValue = Value.isZero() ? "false" : "true";
-  else
-    IntegerValue.toString(PrettyTargetValue);
+  IntegerValue.toString(PrettyTargetValue);
 
----------------
Why do we remove the pretty printing for boolean here? Providing context here will be nice.


http://reviews.llvm.org/D15935