[PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

Alexey Samsonov via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 21 10:19:11 PST 2016


On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber <thakis at chromium.org> wrote:

> thakis added a comment.
>
> After some more debugging, the only thing in this test that's still
> faiilng on Windows is the "unsigned-integer-overflow:do_overflow"
> suppression -- when llvm-symbolizer gets symbols from PDBs it currently
> requires the DIA SDK. If that's not found at cmake time, then
> llvm-symbolizer silently can't symbolize executables with pdb debug info.
>
> The test should probably have some "REQUIRES: symbols" thingie. (I'll also
> fix llvm not finding the DIA SDK in our build setup, but the test will
> still fail for others who don't have that.)
>

Interesting, thanks for digging into this! IIRC the story with Dwarf
support on Windows (both producing it by Clang and consuming it by
llvm-symbolizer) got slightly better recently. Maybe, we can add a compiler
flag to force Clang emit Dwarf data on Windows in our compiler-rt test
suites?


>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D15363
>
>
>
>


-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160121/e6d3e707/attachment-0001.html>


More information about the cfe-commits mailing list