[libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

[Daniel Sanders via cfe-commits]

I just took that as being humble. I'm happy to revert if you want.

From: Marshall Clow [mailto:mclow.lists at gmail.com]
Sent: 21 January 2016 17:29
To: Daniel Sanders
Cc: Hans Wennborg; cfe-commits
Subject: Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

On Thu, Jan 21, 2016 at 9:27 AM, Daniel Sanders <Daniel.Sanders at imgtec.com<mailto:Daniel.Sanders at imgtec.com>> wrote:
Hi,

It was LGTM'd by bcraig.

Specifically, he said "LGTM, but that doesn't mean much."

-- Marshall


From: Marshall Clow [mailto:mclow.lists at gmail.com<mailto:mclow.lists at gmail.com>]
Sent: 21 January 2016 17:25
To: Hans Wennborg
Cc: Daniel Sanders; cfe-commits
Subject: Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

On Thu, Jan 21, 2016 at 9:05 AM, Hans Wennborg <hans at chromium.org<mailto:hans at chromium.org>> wrote:
Hi Marshall,

Is this OK for 3.8?

I have no idea; this is the first I've seen of it.
Apparently it was posted on phab, no one approved it, and it was committed.

In an hour.

-- Marshall




Daniel, I assume we want reviews.llvm.org/D16408<http://reviews.llvm.org/D16408> too when that lands, right?

Thanks,
Hans

On Thu, Jan 21, 2016 at 7:35 AM, Daniel Sanders via cfe-commits
<cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>> wrote:
> Author: dsanders
> Date: Thu Jan 21 09:35:15 2016
> New Revision: 258403
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258403&view=rev
> Log:
> [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.
>
> Reviewers: mclow.lists, hans
>
> Subscribers: bcraig, cfe-commits
>
> Differential Revision: http://reviews.llvm.org/D16406


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160121/c8e75390/attachment.html>