[PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

[Richard via cfe-commits]

LegalizeAdulthood added inline comments.

================
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:50
@@ -49,3 +49,3 @@
 ///      opposite condition.
 ///   4. Implicit conversions of pointer to `bool` are replaced with explicit
 ///      comparisons to `nullptr`.
----------------
aaron.ballman wrote:
> Can you also update for member pointers?
I can explicitly state that; to me "pointers" is a term that includes member pointers.

================
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:77
@@ -74,3 +76,3 @@
 ///      implicit conversion of `i & 1` to `bool` and becomes
-///      `bool b = static_cast<bool>(i & 1);`.
+///      `bool b = i & 1 != 0;`.
 ///
----------------
aaron.ballman wrote:
> To me, this does not improve readability -- I now have to think much harder about operator precedence. Including parens would help significantly, IMO, so that it becomes `(i & 1) != 0`.
To clarify: You'd like to see parens around the expression when it is a binary operator, correct?

When it is a variable, there's no need to add parentheses.


http://reviews.llvm.org/D16308