[PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 19 06:24:11 PST 2016


aaron.ballman added inline comments.

================
Comment at: clang-tidy/misc/CMakeLists.txt:10
@@ -9,3 +9,2 @@
   InaccurateEraseCheck.cpp
-  InefficientAlgorithmCheck.cpp
   MacroParenthesesCheck.cpp
----------------
What about MoveConstantArgumentCheck.cpp?

================
Comment at: clang-tidy/misc/MiscTidyModule.cpp:58
@@ -57,3 +56,1 @@
-    CheckFactories.registerCheck<InefficientAlgorithmCheck>(
-        "misc-inefficient-algorithm");
     CheckFactories.registerCheck<MacroParenthesesCheck>(
----------------
This will break projects that enable the misc-inefficient-algorithm check (which clang 3.7 exposed). Is there a reason to not keep this check registered under this name?

(Perhaps a follow-up patch to allow deprecation of check names so that users are given guidance would make sense.)


http://reviews.llvm.org/D16248





More information about the cfe-commits mailing list