[PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander Droste via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 17 13:46:08 PST 2016

Alexander_Droste added inline comments.

Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPICheckerPathSensitive.cpp:107
@@ +106,3 @@
+      State = State->remove<RequestMap>(Req.first);
+    }
+  }
zaks.anna wrote:
> Alexander_Droste wrote:
> > I need `addTransition()` later to take removed requests into account.
> What you have now, is generating a fork - two successors from the initial predecessor. You need to use the addTransition method that takes a predecessor and pass the ErrorNode there. You should also use the State from that node, not the initial state.
Isn't this covered by the first case? 
If there's an `ErrorNode` pass it to `addTransition()` else just update the state regarding removed requests.


More information about the cfe-commits mailing list