[PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 15 06:27:33 PST 2016

klimek added a reviewer: bkramer.
klimek added a comment.

Adding Benjamin for an additional pair of eyes.
Generally looks good.

Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:351
@@ +350,3 @@
+  // First, match the name.
+  if (!MatchNodeName(Pattern, Node))
Perhaps comment that Pattern will be changed to the prefix, so it's clear afterwards.
(I wonder whether returning a tuple might be slightly easier to understand here)


More information about the cfe-commits mailing list