[PATCH] D15914: [OpenCL] Pipe builtin functions

[Anastasia Stulova via cfe-commits]

Anastasia added inline comments.

================
Comment at: lib/CodeGen/CGBuiltin.cpp:2082
@@ +2081,3 @@
+    if (BuiltinID == Builtin::BIget_pipe_num_packets)
+      Name = "get_pipe_num_packets";
+    else
----------------
prepend "__"  here too!

================
Comment at: lib/Sema/SemaChecking.cpp:291
@@ +290,3 @@
+  bool isValid = true;
+  bool ReadOnly = getFunctionName(Call).find("read") != StringRef::npos;
+  if (ReadOnly)
----------------
Ok, I think we can proceed with this review. You can let the spec be clarified on the side.

================
Comment at: lib/Sema/SemaChecking.cpp:378
@@ +377,3 @@
+  }
+
+  return false;
----------------
I am asking about setArg and not setType!


http://reviews.llvm.org/D15914