[PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

Samuel Benzaquen via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 14 10:28:20 PST 2016

sbenza added inline comments.

Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:29
@@ +28,3 @@
+    Class = Class.trim();
+  return std::vector<std::string>(Classes.begin(), Classes.end());
aaron.ballman wrote:
> I think hasName() will assert if given an empty string, so this should probably also guard against a class list like ",basic_string".
Also changed the separator to be ';' instead of ','.
The latter could be part of a type name. Eg. Foo<A,B>::Bar


More information about the cfe-commits mailing list