[PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 14 07:19:52 PST 2016

alexfh added inline comments.

Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25
@@ +24,3 @@
+  SmallVector<StringRef, 4> Classes;
+  Option.split(Classes, ",");
+  return std::vector<std::string>(Classes.begin(), Classes.end());
aaron.ballman wrote:
> It might be nice for this to be more tolerant of whitespace around the commas.
I don't see much value in this, since it's not someone will change frequently (I guess, once per codebase on average).


More information about the cfe-commits mailing list