[PATCH] D15914: [OpenCL] Pipe builtin functions

Pekka Jääskeläinen via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 14 03:04:39 PST 2016


pekka.jaaskelainen added a comment.

OK. Seems the LLVM 3.8 branching was done, it might be hard to get this in, but should we try and ask the release manager?


================
Comment at: lib/CodeGen/CGBuiltin.cpp:1981
@@ +1980,3 @@
+      const char *Name =
+          (BuiltinID == Builtin::BIread_pipe) ? "read_pipe_2" : "write_pipe_2";
+      // Re-Creating the function type for this call, since the original type
----------------
Shouldn't these have underscores, because they are not reserved OpenCL keywords/builtins? Cannot user functions be called read_pipe_2 or write_pipe_2?


http://reviews.llvm.org/D15914





More information about the cfe-commits mailing list