[PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

Hubert Tong via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 13 16:57:30 PST 2016

hubert.reinterpretcast added inline comments.

Comment at: include/clang/AST/DeclTemplate.h:375
@@ +374,3 @@
+  bool isConcept() const { return TemplatedDecl.getInt(); }
+  void setConcept(bool IC) { TemplatedDecl.setInt(true); }
nwilson wrote:
> hubert.reinterpretcast wrote:
> > The parameter is now unused and should be removed.
> Hmm, I think I should actually use that parameter since it's a bug as is (and would still be if I removed the parameter). I'll plan on doing that unless there is another thought about this.
My interpretation of http://reviews.llvm.org/D13357?id=43469#inline-129592 is that the function should take no parameters (there is no need for a way to set the property to false). Perhaps I misunderstood Richard's intent.


More information about the cfe-commits mailing list