[PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

Rong Xu via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 13 11:51:36 PST 2016

xur marked an inline comment as done.
xur added a comment.

I'll sent the revised patch based on the comments shortly.

Comment at: lib/CodeGen/BackendUtil.cpp:435
@@ +434,3 @@
+  if (CodeGenOpts.ProfileIRInstr) {
+    assert (!CodeGenOpts.ProfileInstrGenerate);
+    if (!CodeGenOpts.InstrProfileOutput.empty())
davidxl wrote:
> What is this asserting about?
Option ProfileInstrGenerate is to be used in Clang instrumentation only. If I reuse this options, I would need to change all the references in clang. I update the comments  in the coming patch.


More information about the cfe-commits mailing list