[PATCH] D16135: Macro Debug Info support in Clang

Amjad Aboud via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 13 00:43:55 PST 2016

aaboud added inline comments.

Comment at: include/clang/AST/ASTConsumer.h:163
@@ -155,1 +162,3 @@
+  /// The caller takes ownership on the returned pointer.
+  virtual std::unique_ptr<PPCallbacks> CreatePreprocessorCallbacks(Preprocessor &PP);
I know that you suggested not to introduce the Preprocessor in anyway to the ASTConsumer.
However, as I could not understand the other way to support macros in Clang without applying a huge redesign, I decided to upload the code I suggested in the proposal.

If you still think that this approach is not the right one, I would appreciate it if you can explain again how to implement the macro support differently.


More information about the cfe-commits mailing list