[PATCH] D15989: [OpenMP] Parsing + sema for "target enter data" and "target exit data" directives.

[Alexey Bataev via cfe-commits]

ABataev added a comment.

You need to add the code/tests for nesting of regions.


================
Comment at: include/clang-c/Index.h:2283
@@ +2282,3 @@
+   */
+  CXCursor_OMPTargetExitDataDirective    = 262,
+
----------------
Target exit and target enter constructs must be implemented in different patches

================
Comment at: include/clang/AST/OpenMPClause.h:2745
@@ -2744,1 +2744,3 @@
+  /// \brief Is this an implicit map type or not.
+  bool MapTypeIsImplicit;
   /// \brief Location of the map type.
----------------
This also must be in a separate patch

================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2665
@@ +2664,3 @@
+    const OMPTargetEnterDataDirective &S) {
+  llvm_unreachable("CodeGen for 'omp target enter data' is not supported.");
+}
----------------
Just ignore this pragma for now, no need to crash a compiler

================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2670
@@ +2669,3 @@
+    const OMPTargetExitDataDirective &S) {
+  llvm_unreachable("CodeGen for 'omp target exit data' is not supported.");
+}
----------------
Just ignore this pragma for now, no need to crash a compiler


http://reviews.llvm.org/D15989