[PATCH] D16062: [analyzer] Rename kind-enumeration values of SVal, SymExpr, MemRegion classes, for consistency.

[Devin Coughlin via cfe-commits]

dcoughlin added a comment.

Looks good to me. Thanks for making this more consistent!


================
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:102
@@ -103,1 +101,3 @@
+    BEGIN_TYPED_REGIONS,
+    FunctionTextRegionKind = BEGIN_TYPED_REGIONS,
     BlockTextRegionKind,
----------------
While we're at it, what do you think about renaming FunctionTextRegion and BlockTextRegion to FunctionCodeRegion and BlockCodeRegion, respectively? The term 'code' is less jargony than 'text' and we already refer to BlockTextRegion as a 'code region' in BlockDataRegion.

================
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:195
@@ -194,2 +194,3 @@
 protected:
   friend class MemRegionManager;
+
----------------
Following up on Anna's question: does MemSpaceRegion need to be a friend of MemRegionManager now?


http://reviews.llvm.org/D16062