[PATCH] D15796: [PATCH] clang-tidy documentation redirects

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 11 06:53:03 PST 2016

aaron.ballman added inline comments.

Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:6
@@ +5,3 @@
alexfh wrote:
> aaron.ballman wrote:
> > > We need to teach add_new_check.py to retain (or automatically generate) these comments then.
> > 
> > I have not touched add_new_check.py for this because add_new_check.py knows nothing about check aliases anyway. Whenever we update add_new_check.py to generate checker aliases directly, that would be a good time to do this work.
> add_new_check.py should do something reasonable with list.rst right away, otherwise the `(redirects to ...)` comments will be lost on each run of the script, which will result in annoying manual work of reverting these changes. Do you need help implementing alias handling in the add_new_check.py script?
Oye, that's a good point. If you don't mind tackling the Python side of things, that would be great.

Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:11
@@ +10,1 @@
\ No newline at end of file

alexfh wrote:
> nit: Could you add newlines at the end of files to remove this annoying line?
Will do.


More information about the cfe-commits mailing list