[PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 11 05:56:05 PST 2016

aaron.ballman added a comment.

In http://reviews.llvm.org/D15443#323043, @adek05 wrote:

> I think this won't work. If there is a problem with the expression inside `throw` or `noexcept` specifier, it will be highlighted inside the parens, never trying to actually access the end location of the function declaration.
> It would be enough if there is a warning/error which would highlight the whole function declaration, because we could check whether it points at `;` or the character in front of it, but I don't know about such warning and I don't know how to smartly look for it.

I think the best way to proceed then is with a test in SourceLocationTest.cpp in the AST unit test suite.


More information about the cfe-commits mailing list