[PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

[Alexey Samsonov via cfe-commits]

Interesting. Do we run test/asan/TestCases/suppressions-interceptor.cc on
Windows? Seems so: I don't see an XFAIL there, and it also uses
suppressions, but with single quote, followed by double quote:

%env_asan_opts=suppressions='"%t.supp"'

Why does it work there?

On Tue, Dec 22, 2015 at 4:35 PM, Nico Weber <thakis at chromium.org> wrote:

> thakis added a comment.
>
> I've looked at it some, and couldn't find a way of escaping quotes that
> lit doesn't strip but that ubsan accepts.
>
> '"c:\foo"' gets its quotes stripped by lit, so does """c:\foo""".
> \"c:\foo\" confuses lit enough that it tries to call lit.util.warning()
> which doesn't exist.
>
> I've XFAIL'd the test on win32 in 256307 for now. Please take a look when
> you're back. Maybe teaching lit about \" escaping is the best fix.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D15363
>
>
>
>


-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160107/bcd37187/attachment.html>