[PATCH] D15958: u8 character literals

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 7 11:40:17 PST 2016


rsmith added a comment.

Thanks!

You also need to update ASTWriterDecl.cpp's construction of `CharacterLiteralAbbrev` to allow three bits of `Kind` rather than two. (You should be able to repro this with a PCH test pretty-printing a `U'x'` literal.)


================
Comment at: lib/Sema/SemaTemplate.cpp:5507
@@ -5506,1 +5506,3 @@
+    // This does not need to handle u8 character literals because those are
+    // of type char, and so can also be covered by an Ascii character literal.
     CharacterLiteral::CharacterKind Kind;
----------------
Ascii -> ASCII


http://reviews.llvm.org/D15958





More information about the cfe-commits mailing list