[PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 6 14:45:55 PST 2016


aaron.ballman added a comment.

Sorry for the delay in reviewing this!

In terms of a test case, presumably you need this because a diagnostic location is incorrect -- would it be possible to write the exception specification such that it is on its own line, and then expect-warning|error|note on the new line instead? e.g.,

  void f()
  noexcept(that does something diagnosable); // expected-warning {{some diagnostic}}

I'm not too keen on adding the change without a test case because we may accidentally break it again in the future. However, the general gist of the code looks correct to me.


http://reviews.llvm.org/D15443





More information about the cfe-commits mailing list