[PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Gábor Horváth via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 6 06:38:35 PST 2016


xazax.hun added inline comments.

================
Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/Utility.h:54
@@ +53,3 @@
+/// \returns variable name for memory region
+std::string variableName(const clang::ento::MemRegion *MR);
+
----------------
zaks.anna wrote:
> Since this takes no arguments but MemRegion, seems like it could go on MemRegion. Please, submit this as a separate patch.
> 
> 
A different implementation to achieve this functionality is proposed here: http://reviews.llvm.org/D15924
The proposed implementation is much lighter and has less functionality, it will not print the name of the struct and the index of the array (which might be unknown in most of the cases). Does that implementation works for you? Is that sufficient? Please review it.


http://reviews.llvm.org/D12761





More information about the cfe-commits mailing list