[PATCH] D15448: [analyzer] SVal Visitor.

[Anna Zaks via cfe-commits]

zaks.anna added inline comments.

================
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/Regions.def:31
@@ +30,3 @@
+// is both instantiated and derived from.
+// Additionally, its kind is not its name with "Kind" suffix,
+// unlike all other regions.
----------------
I'd rather rename the "Kind" suffix. Is that possible?

Having REGION and NORMAL_REGION is strange.

================
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SVals.def:13
@@ +12,3 @@
+// hardcoded, because it is too peculiar and explicit to be handled uniformly.
+// SVal kind-enum values (both base-kinds and sub-kinds) are written out
+// explicitly because those are often named in an unobvious manner.
----------------
Again, we should go ahead and change the kind values if it would make things more uniform. (Can be done in a separate patch committed before this one.)

================
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SVals.def:27
@@ +26,3 @@
+//
+// LOC_SVAL(Id, Kind, Parent) - for sub-kinds of Loc,
+//
----------------
Loc and NonLoc have not been defined yet.


http://reviews.llvm.org/D15448