[PATCH] D15813: [libcxx] Refactoring target_info.py used by lit tests

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 29 16:06:34 PST 2015


EricWF added a comment.

This is NOT correct and it's breaking bots.  I don't want to revert it because I really like the change but it needs to be fixed quickly.

@bcraig You removed the logic that tests if a system provides a given locale. We use this information to enable/disable tests. Please add it back.
I put an inline comment next to the original logic.

Example Breakage: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-arm-linux/builds/780


================
Comment at: test/libcxx/test/config.py:302
@@ -301,3 +242,1 @@
 
-        if target_system in locales:
-            default_locale = locale.setlocale(locale.LC_ALL)
----------------
This test is important!


http://reviews.llvm.org/D15813





More information about the cfe-commits mailing list