[PATCH] D15704: Add some overlooked optnone tests, and tighten up an existing test

Paul Robinson via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 21 16:48:59 PST 2015

probinson created this revision.
probinson added a reviewer: aaron.ballman.
probinson added a subscriber: cfe-commits.

Found some tests we wrote back in the day, but which never made it upstream.

optnone-and-attributes.cpp is a more thorough exercise of optnone attribute interaction than we have currently.

I'm not entirely sure about the value of optnone-class-members.cpp and optnone-templates.cpp as these would seem to be really exercising the main attribute handling in the context of classes, inheritance, and template instantiation; not really that specific to optnone, but it's hard to tell whether general attribute handling tests cover these situations.  I'm happy to contribute them, or throw them away.

The tweak to optnone-def-decl.cpp just makes that last CHECK do what we actually meant it to.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15704.43416.patch
Type: text/x-patch
Size: 11172 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151222/a30f3f2b/attachment-0001.bin>

More information about the cfe-commits mailing list