[PATCH] D15367: Cross-DSO control flow integrity (Clang part)

Evgeniy Stepanov via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 11 16:41:39 PST 2015


eugenis added inline comments.

================
Comment at: lib/CodeGen/CGExpr.cpp:2558
@@ +2557,3 @@
+          false));
+  llvm::MDString *MDS = dyn_cast<llvm::MDString>(MD);
+  llvm::Constant *TypeId =
----------------
pcc wrote:
> What happens if `MD` is not an `MDString`?
assert + check on the caller side


Repository:
  rL LLVM

http://reviews.llvm.org/D15367





More information about the cfe-commits mailing list