[clang-tools-extra] r255199 - There were problems if a relative path is used for an include path, the path will be normalized to ./xxx. I don't know how to test this in a way that will work in a separated source/output environment, but it seems reasonable to assume that -I options won't be for provate directories.

John Thompson via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 9 17:33:09 PST 2015


Author: jtsoftware
Date: Wed Dec  9 19:33:09 2015
New Revision: 255199

URL: http://llvm.org/viewvc/llvm-project?rev=255199&view=rev
Log:
There were problems if a relative path is used for an include path, the path will be normalized to ./xxx.  I don't know how to test this in a way that will work in a separated source/output environment, but it seems reasonable to assume that -I options won't be for provate directories.

Modified:
    clang-tools-extra/trunk/modularize/CoverageChecker.cpp

Modified: clang-tools-extra/trunk/modularize/CoverageChecker.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/modularize/CoverageChecker.cpp?rev=255199&r1=255198&r2=255199&view=diff
==============================================================================
--- clang-tools-extra/trunk/modularize/CoverageChecker.cpp (original)
+++ clang-tools-extra/trunk/modularize/CoverageChecker.cpp Wed Dec  9 19:33:09 2015
@@ -379,8 +379,8 @@ bool CoverageChecker::collectFileSystemH
       continue;
     // Assume directories or files starting with '.' are private and not to
     // be considered.
-    if (file.startswith(".") || (file.find("\\.") != StringRef::npos)
-      || (file.find("/.") != StringRef::npos))
+    if ((file.find("\\.") != StringRef::npos) ||
+        (file.find("/.") != StringRef::npos))
       continue;
     // If the file does not have a common header extension, ignore it.
     if (!ModularizeUtilities::isHeader(file))




More information about the cfe-commits mailing list