[PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

Anna Zaks via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 4 16:43:11 PST 2015


zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.

LGTM.

(Feel free to add comments to the existing code!)

> So the real question is whether (or rather how) the Store should maintain correct region liveness information 

>  after completing its internal garbage collection pass, because there are, in fact, other users of 

>  this information later in the chain, but this seems to be a larger problem without instantly noticeable effects.


Could you give specific (possibly potential) examples of this problem?

We assume that the symbols that are collected do not need to stick around, so no-one "later in the chain" should need them. Except for the cases where we artificially extend liveness by calling addSymbolDependency().


http://reviews.llvm.org/D12726





More information about the cfe-commits mailing list