[PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

Peter Collingbourne via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 4 11:27:27 PST 2015


pcc added inline comments.

================
Comment at: docs/ControlFlowIntegrity.rst:23
@@ -22,6 +22,3 @@
 To enable Clang's available CFI schemes, use the flag ``-fsanitize=cfi``.
-As currently implemented, all of Clang's CFI schemes (``cfi-vcall``,
-``cfi-derived-cast``, ``cfi-unrelated-cast``, ``cfi-nvcall``, ``cfi-icall``)
-rely on link-time optimization (LTO); so it is required to specify
-``-flto``, and the linker used must support LTO, for example via the `gold
-plugin`_. To allow the checks to be implemented efficiently, the program must
+You can enable only a subset of offered :ref:`schemes <cfi-schemes>`.
+As currently implemented, all schemes rely on link-time optimization (LTO);
----------------
This sentence was a little confusing, as it implies that only a subset of schemes are supported. Maybe "You can also enable a subset of available schemes by following [these instructions]."

================
Comment at: docs/ControlFlowIntegrity.rst:78
@@ -50,3 +77,3 @@
 Performance
 ~~~~~~~~~~~
 
----------------
This should also be updated I suppose?

================
Comment at: docs/ControlFlowIntegrity.rst:183
@@ -155,3 +182,3 @@
 ``-fsanitize=cfi-icall`` and ``-fsanitize=function``
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
----------------
Likewise


http://reviews.llvm.org/D15237





More information about the cfe-commits mailing list