[PATCH] D13980: Add "x87" in x86 target feature map

Andrey Turetskiy via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 1 07:56:25 PST 2015


aturetsk added inline comments.

================
Comment at: lib/Basic/Targets.cpp:2551
@@ -2547,3 +2550,3 @@
   case CK_i386:
   case CK_i486:
   case CK_i586:
----------------
"x87 instructions probably work" is more like it, and having feature x87 disabled would mean "x87 instructions definitely don't work". That's what I intended. If feature soft float is specified it takes precedence over feature x87 causing compiler to generate calls instead of X87 instructions.
Support of -m80387/-mno-80387 seems to be a good thing to have in Clang to be compatible with GCC (although briefly looking at GCC's sources these options just seem to be synonyms to -mhard-float/-msoft-float). I can add the flags, but I think that's better to be done in a separate patch.


http://reviews.llvm.org/D13980





More information about the cfe-commits mailing list