[PATCH] D13980: Add "x87" in x86 target feature map

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 25 15:27:32 PST 2015

rsmith added inline comments.

Comment at: lib/Basic/Targets.cpp:2548
@@ +2547,3 @@
+  // All X86 processors but i386 have X87.
+  if (Kind != CK_i386)
+    setFeatureEnabledImpl(Features, "x87", true);
What about `CK_Generic`? Also, if `CK_i486` can be used for the 486SX, we need to exclude it here too. It looks (from wikipedia) like all the "WinChip" flavours of 486 have an x87 unit, but it'd be nice if someone could confirm that. Maybe we should have separate `CPUKind`s for 486 SX versus 486 DX.


More information about the cfe-commits mailing list