r254053 - Fix typo that was being SFINAE'd away (and apparently GCC 4.7.2 rejects-valid on this).

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 24 22:17:24 PST 2015


Possible to test (unit test?) the bug that GCC accidentally found here?

On Tue, Nov 24, 2015 at 6:41 PM, Richard Smith via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Author: rsmith
> Date: Tue Nov 24 20:41:42 2015
> New Revision: 254053
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254053&view=rev
> Log:
> Fix typo that was being SFINAE'd away (and apparently GCC 4.7.2
> rejects-valid on this).
>
> Modified:
>     cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
>
> Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/RecursiveASTVisitor.h?rev=254053&r1=254052&r2=254053&view=diff
>
> ==============================================================================
> --- cfe/trunk/include/clang/AST/RecursiveASTVisitor.h (original)
> +++ cfe/trunk/include/clang/AST/RecursiveASTVisitor.h Tue Nov 24 20:41:42
> 2015
> @@ -291,10 +291,10 @@ private:
>    // class can take a queue, so if we're taking the second arm, make the
> first
>    // arm call our function rather than the derived class version.
>  #define TRAVERSE_STMT_BASE(NAME, CLASS, VAR, QUEUE)
>       \
> -  (decltype(callableWithQueue<CLASS *>(&Derived::Traverse##NAME))::value
>      \
> +  (decltype(callableWithQueue<CLASS>(&Derived::Traverse##NAME))::value
>      \
>         ? static_cast<typename std::conditional<
>       \
>               decltype(
>      \
> -                 callableWithQueue<CLASS
> *>(&Derived::Traverse##NAME))::value, \
> +
>  callableWithQueue<CLASS>(&Derived::Traverse##NAME))::value,   \
>               Derived &, RecursiveASTVisitor &>::type>(*this)
>      \
>               .Traverse##NAME(static_cast<CLASS *>(VAR), QUEUE)
>      \
>         : getDerived().Traverse##NAME(static_cast<CLASS *>(VAR)))
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151124/640d145d/attachment.html>


More information about the cfe-commits mailing list