[PATCH] D14872: PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type

hfinkel@anl.gov via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 24 15:45:50 PST 2015


hfinkel added a subscriber: hfinkel.
hfinkel added a comment.

Please upload this patch with full context, see: http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

> Should we add warning about changes in layout for packed bit-fileds of char type? GCC has it "note: offset of packed bit-field ‘b’ has changed in GCC 4.4" will add if needed.


Warning about this is a good idea. We did something similar when we (re-)introduced sync_fetch_and_nand, see:

  def warn_sync_fetch_and_nand_semantics_change : Warning<
    "the semantics of this intrinsic changed with GCC "
    "version 4.4 - the newer semantics are provided here">,
    InGroup<DiagGroup<"sync-fetch-and-nand-semantics-changed">>;


http://reviews.llvm.org/D14872





More information about the cfe-commits mailing list