[PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

John McCall via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 24 12:20:05 PST 2015

rjmccall added a comment.

This looks fantastic, thanks for doing all that.  Approved with the one minor change.

Comment at: lib/Sema/SemaPseudoObject.cpp:175
@@ -145,1 +174,3 @@
+            PSE->getType(), PSE->getValueKind(), PSE->getObjectKind(),
+            PSE->getRBracketLoc());
One extremely minor tweak: could you organize this like the rest of the pseudo-object expressions, checking for it above and calling a method to rebuild it?


More information about the cfe-commits mailing list