[PATCH] D14887: Make tbm-builtins.c as X86 specific unit test

Eric Christopher via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 20 15:17:18 PST 2015


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

This is fine. One inline comment.

-eric


================
Comment at: test/CodeGen/tbm-builtins.c:2-3
@@ -1,3 +1,4 @@
 // RUN: %clang_cc1 %s -O3 -triple=x86_64-unknown-unknown -target-feature +tbm -emit-llvm -o - | FileCheck %s
+// REQUIRES: x86-registered-target
 // FIXME: The code generation checks for add/sub and/or are depending on the optimizer.
 
----------------
Go ahead and put the REQUIRES underneath the FIXME and add a note to the effect that the REQUIRES can be removed when the FIXME is complete.


http://reviews.llvm.org/D14887





More information about the cfe-commits mailing list