[PATCH] D14506: Porting shouldVisitImplicitCode to DataRecursiveASTVisitor.

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 16 13:28:24 PST 2015


Rather than trying to maintain the horrible duplication between
DataRecursiveASTVisitor and RecursiveASTVisitor, can we just delete
DataRecursiveASTVisitor? RecursiveASTVisitor is data-recursive too these
days (and has a smarter implementation than DataRecursiveASTVisitor's from
what I can see), but doesn't yet apply data recursion in so many cases.

On Mon, Nov 16, 2015 at 1:07 PM, Argyrios Kyrtzidis <akyrtzi at gmail.com>
wrote:

> LGTM.
>
> > On Nov 16, 2015, at 12:32 PM, Ben Craig <ben.craig at codeaurora.org>
> wrote:
> >
> > bcraig added a comment.
> >
> > Ping.  Note that the test is basically a copy / paste job, and the new
> code in DataRecursiveASTVisitor.h is a very direct translation from the
> 'regular' RecursiveASTVisitor.h.
> >
> >
> > http://reviews.llvm.org/D14506
> >
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151116/fca43914/attachment.html>


More information about the cfe-commits mailing list