[PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 16 11:20:40 PST 2015


On Fri, Nov 13, 2015 at 10:45 PM, Alexander Kornienko <alexfh at google.com> wrote:
> alexfh accepted this revision.
> alexfh added a comment.
> This revision is now accepted and ready to land.
>
> Looks good with one nit. Thank you!
>
>
> ================
> Comment at: clang-tidy/cert/ThrownExceptionTypeCheck.cpp:23
> @@ +22,3 @@
> +  if (const auto *FnTy = Node.getType()->getAs<FunctionProtoType>()) {
> +    // If any of the copy constructors is throwing, we will assume that it
> +    // is plausible that the constructor may be selected by the throw and
> ----------------
> The comment is not relevant now.

Thanks! I've commit in r253246.

~Aaron

>
>
> http://reviews.llvm.org/D14619
>
>
>


More information about the cfe-commits mailing list