[PATCH] D9600: Add scan-build python implementation

[Jonathan Roelofs via cfe-commits]

jroelofs added a comment.

Thanks for re-uploading!


================
Comment at: tools/scan-build-py/README.md:39
@@ +38,3 @@
+
+    $ python setup.py build
+    $ python setup.py install
----------------
Mind adding a CMakeLists.txt to drive these from the clang build itself?

================
Comment at: tools/scan-build-py/libscanbuild/__init__.py:7
@@ +6,3 @@
+"""
+This module responsible to run the Clang static analyzer against any build
+and generate reports.
----------------
I think most of this block comment belongs in a new file: clang/docs/ScanBuild.rst

================
Comment at: tools/scan-build-py/tests/functional/src/build/Makefile:1
@@ +1,2 @@
+SRCDIR := ..
+OBJDIR := .
----------------
It'd probably be a good idea to structure these test inputs into their own "projects" so that support for more build system can be added later.

I'd suggest something like:

    tools/scan-build-py/tests/functional/
        simple_makefile
            src
                clean-one.c
                broken-two.c
                clean-one.c
                clean-two.c
            build
                Makefile
        cmake_makefiles
            src
                ...
            build
                CMakeLists.txt
        cmake_ninja
            src
                ...
            build
                CMakeLists.txt

================
Comment at: tools/scan-build-py/tests/unit/__init__.py:16
@@ +15,3 @@
+
+def load_tests(loader, suite, pattern):
+    suite.addTests(loader.loadTestsFromModule(test_command))
----------------
Mind hooking these up so that a LIT test harness can run them too? We use LIT to test pretty much everything else in the llvm project, and it'd be a shame to have a tool with a completely different way of running tests...


http://reviews.llvm.org/D9600