[PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

[Alexey Bataev via cfe-commits]

ABataev marked 2 inline comments as done.

================
Comment at: include/clang/Basic/DiagnosticParseKinds.td:995
@@ -994,1 +994,3 @@
+def err_omp_expected_reduction_identifier : Error<
+  "expected identifier or one of the following operators: '+', '-', '*', '&', '|', '^', '&&' and '||'">;
 
----------------
hfinkel wrote:
> We're not incredibly consistent here, but I think this reads better if we say:
> 
>   '&&', or '||'
> 
> instead of:
> 
>   '&&' and '||'
> 
> (adding the Oxford comma and 'and' -> 'or').
Fixed, thanks.

================
Comment at: lib/AST/Decl.cpp:1463
@@ -1461,1 +1462,3 @@
 
+  // Declare reduction are always replaceable.
+  if (OMPDeclareReductionDecl::classofKind(NewK))
----------------
hfinkel wrote:
> are -> is
Fixed


http://reviews.llvm.org/D11182