[PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 6 10:01:44 PST 2015


alexfh added a comment.

PTAL


================
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+      const CommandLineArguments &Args, StringRef Filename) {
+    ClangTidyOptions Opts = Context.getOptionsForFile(Filename);
+    CommandLineArguments AdjustedArgs;
----------------
The interface should be clearer, if you think about the possibility of having different options for different files. Also, the documentation on the corresponding methods should help. But adding `getOptionsForFile` doesn't hurt.


http://reviews.llvm.org/D14192





More information about the cfe-commits mailing list