[PATCH] D13925: Implement __attribute__((internal_linkage))

Evgeniy Stepanov via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 4 13:23:30 PST 2015


eugenis added a comment.

In http://reviews.llvm.org/D13925#281349, @eugenis wrote:

> Hm, the current implementation allows all of the following:
>
> void f(int a [[clang::internal_linkage]]) {  // 1
>
>   int b [[clang::internal_linkage]];   // 2
>   static int c [[clang::internal_linkage]];  // 3
>
> }
>
> I'll fix (1). Is it OK to allow (2) and (3)? The attribute has no effect because the declarations already have internal linkage, so I'd say it behaves as documented.


Done. Warning on (1) and (2), silently accepting (3).


Repository:
  rL LLVM

http://reviews.llvm.org/D13925





More information about the cfe-commits mailing list