[PATCH] D14345: [analyzer] Update SATestBuild.py to enable a 'download and patch' model for projects.

Gábor Horváth via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 4 12:21:06 PST 2015


xazax.hun added a comment.

Hi!

I think it is great to support this model in these scripts. Do you plan to check the list of the project urls in to the repository as well? I think it would be great to do so, so one can easily reproduce a buildbot error locally, or even run the whole testsuit. It also makes it easier to setup alternative build bots and to contribute projects to the official one.

What do you think?

I have one minor high level note about the handling of patches. I think it in case a project would need more modifications, it is cleaner to have a separate patch file for each kind of them. Maybe it would be worth to support patching the project with multiple patches? E.g. applying all patches with a name prefix.


http://reviews.llvm.org/D14345





More information about the cfe-commits mailing list