[PATCH] D13304: Avoid inlining in throw statement

Jun Bum Lim via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 3 15:38:53 PST 2015


junbuml added a comment.

Thanks Richard for your comment !

If the frond-end is not a good to place for this, I think there are two places we can consider : inliner or prune-eh.

1. In inliner, we can directly check if a CallSite branches an exception region, and then make getInlineThreshold() return a lower threshold.
2. If we want to avoid adding the additional check in inliner, we can move back to PruneEH.cpp(http://reviews.llvm.org/D12979). If NoInline is too strong to use, then I want to suggest to introduce a new attribute and allow ininliner to check the new attribute and decide lower inline threshold for callsites in exception handling regions.

Please let me know any opinion or any better suggestion.


http://reviews.llvm.org/D13304





More information about the cfe-commits mailing list