[PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 3 13:22:32 PST 2015


rmaprath added inline comments.

================
Comment at: buildbot/osuosl/master/config/builders.py:771
@@ +770,3 @@
+             # the -fno-exceptions library build.
+             additional_features={'no-libcxx-tests'}),
+         'category': 'libcxx'},
----------------
jroelofs wrote:
> How bad is the fallout?
I see about 160 test failures. Mostly because those tests have try/catch/throw statements that don't compile under -fno-exceptions, but there are other kinds of failures as well.

One option is to add xfails for those tests and gradually fix them up, this will ensure that we don't regress those tests that are already passing. I've taken the slightly more involved approach and started fixing the tests all in one go. I plan to send a follow-up patch soon with the general idea of the proposed "fix".


http://reviews.llvm.org/D14293





More information about the cfe-commits mailing list